Code Review Request for 4533691 (add Collections.EMPTY_SORTED_SET)

David Holmes david.holmes at
Fri Nov 4 00:40:45 UTC 2011


I see that you have pushed a version of this change and that I was 
listed as a reviewer. However I never saw an updated webrev and there 
was no response to my query below. In fact I never saw any response to 
any of the reviewers comments on this.


On 31/10/2011 10:52 AM, David Holmes wrote:
> Darryl,
> On 29/10/2011 8:44 AM, Darryl Mocek wrote:
>> Hello. Please review this patch to add empty sorted set to the
>> Collections class. Test case provided.
>> Webrev:
> This was an RFE from 2001 - pre-generics. I don't think it makes sense
> to add to the pre-generics pollution by defining EMPTY_SORTED_SET.
>> Additional Notes to Reviewers:
>> The sets resulting from tailSet() headSet() and subSet() normally
>> include the range which was used to create them. Using these methods
>> with emptySortedSet() does not currently set a range on the resulting
>> sets.
> What is the range on an empty set?
> David
> -----
>> Thanks,
>> Darryl

More information about the core-libs-dev mailing list