Codereview request for 7096080: UTF8 update and new CESU-8 charset

Xueming Shen xueming.shen at
Mon Nov 7 20:30:40 UTC 2011

Thanks Alan,

The webrev has been updated accordingly to address your comments (the
commented out isMalformed2 has been removed, copyright updated, bugid

And thanks for Ulf for the detailed review.


On 10/28/2011 09:14 AM, Alan Bateman wrote:
> On 28/09/2011 20:18, Xueming Shen wrote:
>> Hi,
>> [I combined the proposed charge for #7082884, in which no one appears 
>> to be
>> interested:-) into this one]
>> :
>> <>
> I don't know if you are still looking for a reviewer for this (seems 
> like Ulf has gone through this in detail, thanks Ulf).
> Overall it looks fine to me. Minor comment is that in then 
> maybe isMalformed2 should be removed completely, maybe move some of 
> the comment in the decode methods. Another minor nits is that the date 
> on is 2000-2010 where I assume it should be 2011. In 
> then it might be better to just remove L196 as it might 
> confuse future maintainers. I would also suggest adding the bugID to 
> the list of bugs in the tests too as someone these references are useful.
> -Alan.

More information about the core-libs-dev mailing list