code review request : 7091388:Regular unexplained npe's from corba libs after system has been running for days

Alan Bateman Alan.Bateman at
Thu Nov 10 19:25:26 UTC 2011

On 07/11/2011 11:42, Seán Coffey wrote:
> currently not live on but hope to get it up there shortly :
> I'm porting fix for 7091388 forward to JDK8 (and then 7u)
> This is a fix in the CDRInputStream_1_0.close()/ 
> CDROutputStream_1_0.close() methods where shared buffers may be 
> incorrectly closed out if the System.identityHashCode method 
> incorrectly identify two buffers as being equal.
> Fix is to use the "==" operator to test if buffers are equal instead 
> of System.identityHashCode
The approach looks okay to me. I guess there isn't any need for these 
methods to be protected and it's just for consistency with the existing 


More information about the core-libs-dev mailing list