Code Review Request for 6578042

Alan Bateman Alan.Bateman at
Tue Nov 15 22:29:57 UTC 2011

On 15/11/2011 19:51, Darryl Mocek wrote:
> I've modified the fix per feedback (thanks all).  System.clearProperty 
> now attempts to get the property with the specified key.  If there is 
> such a property, and the value is a String, remove the property and 
> return the value removed, otherwise return null (if it is null) or 
> throw CCE (if it's not null and is not a not remove the 
> property here).  Webrev can be found here:
Thanks for changing the approach, I think this is much better. On the 
implementation then I assume you need to synchronize around the 
get+remove. The regression tests isn't in this webrev but you might want 
to go back over the comments on the original test. Also didn't we agree 
to also update Properties.getProperty to make it clear that it returns 
null when the value is not a String?


More information about the core-libs-dev mailing list