Code review - 6731620 TEST_BUG: java/util/Timer/ is too optimistic about the execution time of System.out.printf

Rémi Forax forax at
Mon Nov 21 13:52:39 UTC 2011

  Le 21/11/2011 14:05, Alan Bateman a écrit :
> On 21/11/2011 12:45, Alan Bateman wrote:
>> On 21/11/2011 12:17, Gary Adams wrote:
>>> Here's a fresh bug number to handle the volatile revision (pun 
>>> intended)
>>>   7114125 java/util/Timer/ should use volatile cross 
>>> thread variable declaration
>>> Here's a fresh webrev for the proposed adjusted fix.
>> This looks good to me.
> I see David has reviewed this too so I've pushed this change (minus 
> the addition to the @bug tag). I've also pushed your fix to the 
> ThreadGroup/ test so I think this means we're now caught up 
> on all your contributions to these tests.
> -Alan.

Alan, David and Gary,
I'm sorry to have proposed to use an array of Thread forgetting that
the array was accessed by more than one thread.


More information about the core-libs-dev mailing list