Codereview request: 7109837 Provide a mechanism for computing an Adler32 checksum for the contents of a ByteBuffer

Alan Bateman Alan.Bateman at
Thu Nov 24 11:13:09 UTC 2011

On 23/11/2011 19:39, Xueming Shen wrote:
> Thanks Alan.
> The webrev has been updated accordingly.
Minor nit but we should probably use {@code null} instead of <tt>null</tt>.

I think the opening sentence "Updates the Adler32 checksum with the 
specified ByteBuffer" could be improved, how about: "Updates the 
checksum with the bytes from the given buffer". Same thing in CRC32.

Thanks for adding the test to check the buffer position/limit after the 

One small concern with the test is that it's a bit of a stress test and 
will run for a long time. What you would think about having a -shortrun 
option. Look at test/java/util/Arrays/ for example where I 
dialed down Vladimir's test so that it runs quickly in the test runs but 
is more comprehensively when run without any options.


More information about the core-libs-dev mailing list