Codereview request: 7109837 Provide a mechanism for computing an Adler32 checksum for the contents of a ByteBuffer

Xueming Shen xueming.shen at
Thu Nov 24 22:47:46 UTC 2011

Alan, Ulf,

Webrev has been updated accordingly

(1) {@code}
(2) better wording for opening sentence as suggested
(3) added -benhmark option for TimeCheckSum, so only do the benchmark run
      (with 100000 iteration) when  this option is manually specified. 
Without the
      option, it runs as a "normal"  regression test with iteration 1.
(4) to use "ratio" of "time of ByteBuffer: time of byte[]" as


On 11/24/2011 3:13 AM, Alan Bateman wrote:
> On 23/11/2011 19:39, Xueming Shen wrote:
>> Thanks Alan.
>> The webrev has been updated accordingly.
> Minor nit but we should probably use {@code null} instead of 
> <tt>null</tt>.
> I think the opening sentence "Updates the Adler32 checksum with the 
> specified ByteBuffer" could be improved, how about: "Updates the 
> checksum with the bytes from the given buffer". Same thing in CRC32.
> Thanks for adding the test to check the buffer position/limit after 
> the update.
> One small concern with the test is that it's a bit of a stress test 
> and will run for a long time. What you would think about having a 
> -shortrun option. Look at test/java/util/Arrays/ for 
> example where I dialed down Vladimir's test so that it runs quickly in 
> the test runs but is more comprehensively when run without any options.
> -Alan

More information about the core-libs-dev mailing list