Codereview request: 7109837 Provide a mechanism for computing an Adler32 checksum for the contents of a ByteBuffer

Alan Bateman Alan.Bateman at
Fri Nov 25 20:31:05 UTC 2011

On 25/11/2011 20:07, Xueming Shen wrote:
> If we run this test as a auto regression test, as we do in jtreg or 
> jprt job, I don't think the "benchmark"
> number matters and the resulting numbers probably will not be checked 
> (manually),  especially  1000
> or even 10000 normally might not bring ina reliable benchmark number 
> anyway, so I guess it probably
> not worth the testing circle to iterate more than 1. But not a big 
> deal for me, if you strongly believe
> a 10000 iteration result might help some time, I can check in the 
> iteration as 10000.
> -Sherman
I don't have a strong opinion on this, one iteration is fine.


More information about the core-libs-dev mailing list