zlib 1.2.3 -> 1.2.5
xueming.shen at oracle.com
Tue Nov 29 17:29:47 UTC 2011
The test case has been updated accordingly to
(1) reduced the data size to 500k
(2) dialed down the loop iteration to 5
so it runs much faster now.
The webrev has been updated.
On 11/29/2011 02:23 AM, Alan Bateman wrote:
> On 28/11/2011 22:06, Xueming Shen wrote:
>> Here is the webrev for upgrading the bundled zlib from 1.2.3 to 1.2.5
>> for JDK8
>> The changes to the original zlib source code (other than the
>> copyright attachment)
>> is at
>> For you reference, the 1.2.3 upgrade webrev can be found at
> Thanks for doing this, the upgrade looks fine to me (assuming that
> zlib1.2.3 is deleted).
> One concern about the test is that it would appear to be long running.
> I grabbed it and tried it on my system with zlib1.2.3 and it took
> about 25s, and just over 1m on a much older/slower machine. Maybe the
> innermost loop could be dialed down, say to 5. It might be best to
> drop the /timeout=1000 as the right way to increase the timeout on
> really slow machines is to run with -timeoutFactor:N.
> Minor comment on the test is that new Random(new
> Date().getTime()).nextBytes(dataIn) is a bit odd. Also might be nicer
> if check didn't declare that its throws Throwable.
More information about the core-libs-dev