code review request: 7051946: Runtime.exec(String command) / ProcessBuilder command parsing issues
David.Holmes at oracle.com
Wed Sep 14 02:14:46 UTC 2011
On 14/09/2011 3:26 AM, Alan Bateman wrote:
> Michael McMahon wrote:
>> Can I get the following webrev reviewed please?
> I scanned this briefly (I haven't done a detailed code review) but one
> initial comment is that Runtime.exec will now throw
> IllegalArgumenetException for that a case that isn't specified. The current
> javadoc says it is only thrown "If command is empty" and maybe this needs to
> be re-examined. I assume such cases would cause IOException to be thrown today.
Aside: ProcessBuilder.start seems to have a number of undocumented failure
modes compared to Runtime.exec
I can't comment on the details of the windows logic, but the basic code
refactoring seems okay to me.
More information about the core-libs-dev