JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

Joe Darcy joe.darcy at oracle.com
Mon Sep 19 01:10:29 UTC 2011

Alan Bateman wrote:
> joe.darcy at oracle.com wrote:
>> Hello.
>> Please review the changes to address
>>    7091682 "Move sun.misc.FpUtils code into java.lang.Math"
>>    http://cr.openjdk.java.net/~darcy/7091682.0/
>> As implied by the synopsis, where appropriate JDK-implementation code 
>> used to provide functionality in java.lang.Math and 
>> java.lang.StrictMath is moved out of sun.misc.* and into 
>> java.lang.Math.  Uses of methods available in java.lang.Math and 
>> switched to that entry point as opposed to the sun.misc one.  
>> Additionally, the sun.misc methods whose implementation was moved 
>> were also deprecated.
>> Later in JDK 8, I will probably add some of the remaining 
>> un-deprecated methods in sun.misc.FpUtils as 
>> java.lang.Math/StrictMath methods.
>> Thanks,
>> -Joe
> Looks good to me. Some of the if-then-elses are a bit inconsistent but 
> no big deal. I did a quick search through the repository and I see 
> that java.util.Formatter uses FpUtils.getExponent and scalb and maybe 
> they should be changed to use Math.

Thanks for noticing that Alan; I'm remove some additional uses of 
FpUtils in Float, Double, and Formatter before the push.



More information about the core-libs-dev mailing list