JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"

Joe Darcy joe.darcy at oracle.com
Thu Sep 22 23:29:55 UTC 2011

On 9/22/2011 2:07 PM, Ulf Zibis wrote:
> Am 22.09.2011 19:18, schrieb Ulf Zibis:
>> I'm wondering why you don't have moved concerning documentation from 
>> sun.misc.* to java.lang.(Strict)Math. E.G.: The comment on the scalb 
>> operations:
>> /*
>>  * The scalb operation should be reasonable ...
>>  */
>> To save some source code footprint and allow better overview, I 
>> suggest to erase all javadoc of the moved methods except the 
>> deprecated note.
> BTW: Is it valid use annotation with argument like: @Deprecated("Use 
> Math.scalb.")
> instead redundant javadoc tag?

No; the @Deprecated annotation with an informative @deprecated javadoc 
tag describing what to do instead is the proper style.

The @Deprecated annotation type was intentionally defined as marker 
annotation without a string value.


More information about the core-libs-dev mailing list