Review Request: 7193339 Prepare system classes be defined by a non-null module loader

serguei.spitsyn at serguei.spitsyn at
Thu Aug 23 21:54:43 UTC 2012

Looks good.


On 8/23/12 12:33 PM, Mandy Chung wrote:
> On 8/23/2012 11:58 AM, Alan Bateman wrote:
>> On 23/08/2012 18:43, Mandy Chung wrote:
>>> This change is to bring the jdk modularization changes from jigsaw 
>>> repo [1]
>>> to jdk8.  This allows the jdk modularization changes to be exposed for
>>> testing as early as possible and minimize the amount of changes carried
>>> in the jigsaw repo that helps sync up jigsaw with jdk8/jdk9.
>>> Webrev at:
>> This looks good to me and it's good to have these changes in jdk8.
>> One suggestion for ReflectUtil is to add a private static boolean 
>> isAncestor method as I think that would make the checks in 
>> needsPackageAccessCheck easier to read. Also in ClassLoader you could 
>> use just use needsClassLoaderPermissionCheck(from,to).
> Done.  This is a good cleanup I considered to do too but missed in the 
> previous webrev.
> Thanks for the review.
> Mandy

More information about the core-libs-dev mailing list