Review Request: 7193406 - Clean-up JDK Build Warnings in java.util, java.io
forax at univ-mlv.fr
Fri Aug 24 10:17:13 UTC 2012
On 08/23/2012 11:46 PM, Dan Xu wrote:
> Please review the fix of CR 7193406 at
> It cleans up warnings in the following java files.
> And it enables fatal warning flag in the following make file.
> In FilePermission.java file, I make one change to its method signature,
> public Enumeration elements() ==> public Enumeration<Permission>
> I am not sure whether it will cause an issue of backward
> compatibility. Please advise. Thanks!
> - Dan
I'm not sure to like the fact that you introduce some local variables
just to get ride of some warnings given that Hotspot compilers are
sometimes sensitive to that.
I think this practice should be discussed on this list before committing
so is it a good idea to add a temporary local variable to fix a generics
warning or should @SuppressWarnings should be set on the whole method ?
More information about the core-libs-dev