Review Request: 7193406 - Clean-up JDK Build Warnings in java.util,

Ulf Zibis Ulf.Zibis at
Thu Aug 30 13:23:23 UTC 2012

Am 30.08.2012 01:03, schrieb Stuart Marks:
> On 8/29/12 3:50 AM, Ulf Zibis wrote:
>>>> In file, I make one change to its method
>>>> signature,
>>>>      public Enumeration elements()  ==> public Enumeration<Permission>
>>>>      elements()
>> Actually the whole method is synchronized. To make this more clear, I suggest:
>>   798     public synchronized Enumeration<Permission> elements() {
>>   799         // Convert Iterator into Enumeration
>>   800         return Collections.enumeration(perms);
>>   801     }
> Hi Ulf,
> You're making some reasonable suggestions for general code cleanup. However, this is not general 
> code cleanup. Several issues have already been raised that are directly relevant to the warnings 
> fixes. I'd like to get these resolved, to get Dan's fix integrated, and to keep Dan focused on 
> further warnings cleanup, without getting bogged down in other code cleanup issues.

As there were cleanups in javadoc, I thought, some small ones could be included too, at least the 
synchronized stuff, as this line was already touched..
OK, thanks for your feedback.


More information about the core-libs-dev mailing list