Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK
Kurchi Subhra Hazra
kurchi.subhra.hazra at oracle.com
Wed Jun 20 16:07:53 UTC 2012
I was just going through the patches, there are some more fallthrough
src/share/classes/java/util/regex/Pattern.java.(for example in line 2247).
Are these not generating warnings?
On 6/20/12 7:30 AM, Martijn Verburg wrote:
>>> Hi all,
>>> Apologies, I didn't check that attachments were stripped. The patches
>>> can be found at:
>> Hi Martijn,
>> the two patches looks good.
>> A minor nit, why is there a space between the '(' and the readUByte() in
> Thanks for the quick review! No reason on the whitespace, I've fixed that now.
> Quick question. Is there a checkstyle or jcheck that we should be
> applying to any corelib patches going forwards?
More information about the core-libs-dev