RFR 7065380 : Allow Collections.sort to sort Collections.singletonList() result

David Holmes david.holmes at oracle.com
Thu Mar 1 20:10:05 UTC 2012

Looks good to me.

A superfluous comment in the test:

47         // 7065380


On 2/03/2012 5:50 AM, Mike Duigou wrote:
> Hello all;
> Currently Collections.sort() refuses to sort the lists which result from calling Collections.singletonList(). This makes some sense because the singleton lists are immutable but they are also alway sorted.
> This patch allows Collections.sort() to be used with empty and singleton lists of all types. A short circuit return is provided for lists of length 0 and 1 as they are already sorted.
> WEBREV: http://cr.openjdk.java.net/~mduigou/7065380/0/webrev/
> For the unit test ignore the diffs and view the "New" file--webrev doesn't understand "hg copy".
> Thanks,
> Mike

More information about the core-libs-dev mailing list