Suggestion about including pthread.h
david.holmes at oracle.com
Thu Mar 8 11:59:59 UTC 2012
On 8/03/2012 6:09 PM, Shi Jun Zhang wrote:
> On 3/2/2012 5:05 PM, Alan Bateman wrote:
>> On 02/03/2012 07:53, David Holmes wrote:
>>> Yes we need to move to a more capability based inclusion &
>>> conditional compilation mechanism. I'm not sure if the build-infra
>>> project is tackling this particular case.
>> Yes, I think moving to a more capability based compilation is where
>> build-infa wants to go, although clearly it's going to take a long
>> time. As I see, that project will put the infrastructure in place and
>> then it's up to each area to gradually eliminate the ifdef platform
>> usages. I don't think they will all go away but with effort then
>> things should be more portable than what we have now.
> There is still no reply from build infra project and even if it is in
> build infra, it will take a long time to merge back to trunk. But this
> including pthread problem really affects AIX platform. I'm thinking we
> can use #ifndef __solaris__ form because all other POSIX-conformant
> platforms (BSD, Mac, AIX, ...) except Solaris need to include pthread.h.
> Here is the webrev:
If Linux==BSD==AIX then changing things to be !solaris might be right,
but it is not clear that is the case. In NativeThread.c changing "ifdef
linux" to "ifndef solaris" seems simply wrong - as it changes the sense
of all those blocks for BSD! But then I don't see any BSD code in there?
More information about the core-libs-dev