Request for review: updated 2 files to use generic type

Rémi Forax forax at
Wed May 2 10:32:49 UTC 2012

On 05/02/2012 11:41 AM, David Holmes wrote:
> On 2/05/2012 6:30 PM, Alan Bateman wrote:
>> On 02/05/2012 09:01, Sean Chou wrote:
>>> Hi all,
>>> I updated 2 files(src/share/classes/sun/font/,
>>> src/share/classes/sun/java2d/ to use generic type, but 
>>> I'm
>>> not sure if I modified too much. Especially I changed the return 
>>> type of
>>> Disposer.getQueue from ReferenceQueue to ReferenceQueue<Object> .
>>> The webrev is:
>>> Please take a look.
>> Sean - I think it would be better to bring this to 2d-dev.
> I second that. The signature changes will require additional 
> approvals. The basic rawtype removals might also be targetted on one 
> of the cleanup days.
> Also diamond <> should be used where applicable.

ReferenceQueue<Object> is Ok for me given that the singleton Disposer is 
used for many different objects,
but I've trouble to understand why the Disposer doesn't manage it's own 

Also there also a bunch (almost all) of static fields that should be 
static final.

> David
>> -Alan.


More information about the core-libs-dev mailing list