Request for Review : CR#6924259: Remove String.count/String.offset

Mike Duigou mike.duigou at
Fri May 25 13:48:55 UTC 2012

> A non-material comment is that there are a couple of style changes that I found annoying. Everyone is an expert on such matters, I'm not, but the one that bugged me a bit was adding the space after the cast, eg:
> (toffset > (long) value.length - len)
> I found myself needing to re-read it to see if the cast applied to value.length or value.length-len. It's a minor point but you know what I mean.

I too mostly prefer casts without a space. The code was reformatted with an IDE because I'm actually terrible about being consistent in my formatting. Mechanically formatted code, like mechanically separated meat, lacks any sense of what is readable to a human. I will remove some of the spaces.


More information about the core-libs-dev mailing list