Review Request: CR#8001634 : Initial set of lambda functional interfaces

Alan Bateman Alan.Bateman at
Thu Nov 1 08:29:58 UTC 2012

On 31/10/2012 20:16, Mike Duigou wrote:
> There's a large set of library changes that will be coming with Lambda. We're getting near the end of the runway and there's lots left to do so we want to start the process of getting some of the more stable pieces put back to the JDK8 repositories.  We've spent a some time slicing things into manageable chunks. This is the first bunch. We'd like to time-box this review at one week, since there are many more pieces to follow.
> :
This mail concerns some side issues that are nothing to do with the 
functional interfaces themselves, so file this separately to the 
feedback on the API.

jdk8 still builds with the old build system and I don't think there is a 
transition date yet. Even after the transition then I expect that the 
old build system will need to be kept on life support for a few weeks. I 
just mention this as I don't see any updates to make/java/java/* in the 
webrev. As the functions are in their own package and are pure java then 
they just need to be compiled. I think this should do it (no need to 
list specific classes):

--- a/make/java/java/Makefile
+++ b/make/java/java/Makefile
@@ -62,6 +62,8 @@ include FILES_c.gmk
  include FILES_c.gmk
  include FILES_java.gmk
  include Exportedfiles.gmk
+AUTO_FILES_JAVA_DIRS = java/util/functions

  ifeq ($(PLATFORM),windows)
  FILES_java +=  java/io/ \

The other minor thing is the copyright headers, a few of the interfaces 
(such as Block and Mapper) have three dates in the header. There are 
scripts around that check the format, might be worth running those to 
avoid noise during the reviews.


More information about the core-libs-dev mailing list