Review request for 8001536 updated

Alan Bateman Alan.Bateman at
Thu Nov 1 18:03:25 UTC 2012

On 31/10/2012 15:08, Lance Andersen - Oracle wrote:
> Here is revised webrev taking into account Remi's suggestions
I skimmed over the updated webrev and the changes mostly look okay to me.

One comment on the clone method is that "The internal {@code Blob} field 
will be set to null" doesn't seem right. Shouldn't this say that the 
resulting object doesn't have an underlying Blob?

I don't know if you want formatting/type comments but a couple of nits:
- In both classes then it looks like the javadoc comment on equals has 
been shunted right by space
- In equals then "if(" seems to be missing a space between "if" and "(". 
There's another one in readObject.
- The spacing around "+" in hashCode is a bit odd, it doesn't matter of 
course but would be good to be consistent
- the first line of both readObject has also been shunted right by one 


More information about the core-libs-dev mailing list