RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

Kumar Srinivasan kumar.x.srinivasan at oracle.COM
Fri Nov 2 21:00:45 UTC 2012

Hi David, Kelly, Erik,

as Kelly stated the jdk only build, uses the compiler from the
import JDK, this works with -source 8 -target, which was prepped
by Joe earlier.  I also checked with a jdk only jprt build submission,
which exposed another location that needed a bump.

I have fixed the new infra build as well as Erik suggested,  here is the new

The delta webrev ie. changes since the last reviewed:


> If someone is doing a partial build (without langtools) the import jdk is used for javac compilation, not the boot jdk javac.
> This has not changed.
> The boot jdk javac is only used to build langtools and the hotspot serviceability agent.
> -kto
> On Oct 31, 2012, at 7:22 PM, David Holmes wrote:
>> Hi Jon,
>> On 1/11/2012 12:09 PM, Jonathan Gibbons wrote:
>>> David,
>>> For a long time now, the JDK 8 langtools repo has accepted -source 8 and
>>> -target 8, so this should not affect which version of langtools you need
>>> to use. Of course, you do need to make sure that these options are not
>>> used with the bootstrap javac, which will typically be from JDK 7.
>> That wasn't quite my query/concern - I wasn't very clear. If someone is doing a partial build, ie JDK repo only, they will now have to use a JDK8 boot JDK (or point to suitable langtools import?) - correct? (Where a full build would use the current langtools to build the rest of the JDK.)
>> Just trying to understand if there may be places (JPRT?) where we've so far been able to use a JDK7 boot JDK but will no longer be able to.
>> Thanks,
>> David
>>> -- Jon
>>> On 10/31/2012 06:38 PM, David Holmes wrote:
>>>> Hi Kumar,
>>>> So after this jdk8 builds will have to use current langtools javac in
>>>> order to work?
>>>> The corresponding changes to the new build system will be needed as well.
>>>> David
>>>> On 1/11/2012 3:43 AM, Kumar Srinivasan wrote:
>>>>> Hello,
>>>>> Please review changes to rev up the default -source and -target for jdk
>>>>> compilation,
>>>>> thus producing v52.0 class files.
>>>>> Bug is here:
>>>>> https://jbs.oracle.com/bugs/browse/JDK-8001191
>>>>> Webrev is here:
>>>>> http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/
>>>>> Note: this webrev is generated against the master repository but changes
>>>>> will be
>>>>> pushed via tl after the tl-master sync is completed.
>>>>> Thanks
>>>>> Kumar

More information about the core-libs-dev mailing list