Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

Alan Bateman Alan.Bateman at
Tue Nov 13 11:12:11 UTC 2012

On 13/11/2012 03:17, Sean Chou wrote:
> Hi Alan,
> Here is the updated webrev: 
> <>  .
I think this looks much better.

One final comment, in createJarFile it looks like you forgot to remove 
the close when you changed it to use try-with-resources. It's harmless, 
just would be good to remove it before you push the change (no need to 
generate a new webrev for this).


More information about the core-libs-dev mailing list