Review/comment needed for the new public java.util.Base64 class
xueming.shen at oracle.com
Thu Oct 18 14:04:49 UTC 2012
On 10/18/2012 6:19 AM, Ulf Zibis wrote:
> Hi Sherman,
> you could create the code table by help of a String constant, which
> would speed up the loading and save a little footprint on the class
> file. (you have forgotten those tricks from sun.nio.cs coders? ;-) )
The implementation probably needs more tuning.
> But my main question:
> Why don't you enqueue those coders in the well known sun.nio.cs.ext
Base64 encoding is not a charset. Mainly it is supposed to be
Even for byte<=>char/String, Base64 "encode" byte to char/String
from char/String to byte. The "wrong" direction compared to charset
> At least, I think, class Base64 should be hosted in java.nio.charset
> rather than common java.util.
> As I believe, that the usage of this encoding is far from common
you might be surprised how "common" it might be:-)
> , adding it to the lazy loaded charsets.jar IMO should be more
> Am 18.10.2012 04:10, schrieb Xueming Shen:
>> Webrev has been updated with following changes
>> (1) added a pair of en/decode(ByteBuffer src, ByteBuffer dst) methods
>> (2) some minor spec clarification regarding the "end of decoding"
>> (3) performance tuning.
>> some performance scores:
More information about the core-libs-dev