Review request for 7192302 Remove JDBCRowSetImpl dependency on java.beans

Alan Bateman Alan.Bateman at
Thu Sep 6 13:00:06 UTC 2012

On 06/09/2012 13:40, Lance Andersen - Oracle wrote:
> Here is the updated webrev
> I know there is more clean-up that can be done to remove other Rave added code (such as the removal of set/getPreparedStatement/Connection/ResultSet), I want to keep the focus to just removing PropertyChangeSupport.  SQE and RowSet TCKs continue to pass with these changes.
Your previous mail uses the word "nuke", I was thinking the same thing :-)

The latest webrev looks okay except that in one of the constructors you 
have removed a call to ensure that the connection is established, I'm 
not sure about the significance of that.

I also see there are a couple of residual references to "Rave" that can 
probably be pulled, these seem to be related to the 
PropertyChangeListener support.

One method that looks like it could be removed too is setConcurrency but 
I agree that keeping focused on just removing the beans dependency is 
right for now.


More information about the core-libs-dev mailing list