Do not let internal JDK zlib symbols leak out of fastdebug

Kelly O'Hair kelly.ohair at
Fri Mar 1 16:19:44 UTC 2013

On Mar 1, 2013, at 6:44 AM, Alan Bateman wrote:

>> It's hard to find something more standard than stddef.h.
> It's hard to find something as non-standard as Windows. My point was we just need to double check that this builds okay on Windows, which is does.

The only issue I have seen with adding includes, even standard ones like these, is that they tend
to drag in so many more hidden include files, and there could be a chance at a compiler error.
But that's fairly easy to diagnose, either it builds or it doesn't.
What makes it a bit dangerous is that if it creates warning errors that are significant, we probably
won't easily see them because we are not using -Werror across the board. :^(

Having said that, my job is to be paranoid, and this does border on paranoia, so I say add the stddef.h
and damn the torpedos, full steam ahead.


More information about the core-libs-dev mailing list