RFR: 8009428 and 8009429 - Profile related fixes and clean ups

David Holmes david.holmes at oracle.com
Tue Mar 12 07:10:59 UTC 2013

Hi Alan,

On 11/03/2013 6:54 PM, Alan Bateman wrote:
> On 11/03/2013 01:24, David Holmes wrote:
>> I had overlooked the need to update the ct.sym creation tool to
>> recognize the new syntax in the profile spec file. That process also
>> uncovered a few bugs in the listing that needed correcting.
>> The javadoc generation of compact profile information is not quite
>> right, but that will be handled in a seperate bug.
>> Updated webrevs at:
>> http://cr.openjdk.java.net/~dholmes/8009428_8009429.v2/
> The changes to the top-level and jdk repo look good to me. As per my
> original comments, I'm happy to see profile-rtjar-includes.txt changed
> to be much easier to maintain. The assumption that jdk.** is in compact1
> is okay for now but I'm sure that will need to be changed when that
> namespace is used more.

Yes we will change this as we need to, once other packages come into play.

> For the intro comment in profile-rtjar-includes.txt then it might be
> useful to beef up the comment to explain what happens when an API
> package does not match one of the rules, ie: does it go into compact1,
> only the full JRE, or none. Also make it explicit that the form
> DialogCallbackHandler*.class should not be used. I suggest this for the
> benefit of someone needing to tweak this in the future.

I have updated the webrev with additional commentary.

> I have played with com.sun.tools.javac.sym.Profiles and so the changes
> to MakefileProfiles look okay to me but Jon should really be the
> reviewer for this. One thing about maxProfiles is that it should match
> Profile.values.length maybe maxProfiles should not be hardcoded to 4.

Sorry but what is Profiles.values.length? Previously we inferred the 
number of profiles from the fact that we failed to find PROFILE_n for 
some value n. That can't work (easily) now hence the hard limit.

> Another thing is whether to add a test or beef up an existing test
> (ProfileOptionTest.java in particular).

What exactly is it that you would like to test for?


> -Alan.

More information about the core-libs-dev mailing list