Review Request: JDK-8001334 - Remove use of JVM_* functions from java.io code
dan.xu at oracle.com
Tue Mar 12 18:01:01 UTC 2013
On 03/12/2013 08:19 AM, Alan Bateman wrote:
> On 11/03/2013 23:43, Dan Xu wrote:
>> Thanks for all your comments. I have updated the fix accordingly.
>> Please see the webrev at
>> For the language concern in getLastErrorString(char *buf, size_t len)
>> function, I will log another bug and address it later. Thanks!
> You've addressed all my comments but I think I may have confused you
> on one point when I mentioned O_APPEND. You've changed handleAppend to
> use fcntl(F_GETFL) and check if the flag is set but this will happen
> on every write in append mode and we don't want that. I think you can
> simply change IO_Append to be handleWrite or else have handleAppend
> call handleWrite. The jboolean flag isn't needed for the *nix case.
Do you mean directly map IO_Append to handleWrite in io_util_md.h for
the *nix case? And then where do we check the O_APPEND flag in our code?
Or do we require users to open the file with O_APPEND flag? Thanks!
More information about the core-libs-dev