Review Request for 8005428: Update jdeps to read the same profile information as by javac

Mandy Chung mandy.chung at
Thu Mar 14 16:56:16 UTC 2013

On 3/14/13 8:20 AM, Alan Bateman wrote:
> On 13/03/2013 20:23, Mandy Chung wrote:
>> This fix removes the temporary workaround for jdeps to print the 
>> profile information.  The profiles information is embedded in ct.sym 
>> generated during the jdk build.  jdeps will read ct.sym and parse the 
>> annotation to determine which profile a class belongs to.   I have 
>> extended the test to  test the profile information.
>> Webrev at:
> I went through the webrev and it looks good to me (educational too as 
> I only had a superficial understanding of the ct.sym before this).

Thanks for the review. Updated webrev:
> In initProfiles then this might be less code to get the right path:
>     Path home = Paths.get(System.getProperty("java.home"));
>     if (home.endsWith("jre"))
>         home = home.getParent();
>     Path ctsym  = home.resolve("lib").resolve("ct.sym");
> For consistency then the constants with the annotation types should 
> probably be uppercase.

I have made these changes.

> You've moved into the test tree to be used by the 
> test. I think that is okay for the types that are tested but one thing 
> to mention is that these properties file is out of date in a few 
> places now.

Yes I didn't bother to update it as it's only used by the test.  I added 
a comment to avoid any confusion.


More information about the core-libs-dev mailing list