RFR: 8023978: [TEST_BUG] launcher tests must exclude platforms without server vm

Mandy Chung mandy.chung at oracle.com
Fri Nov 15 03:11:07 UTC 2013

On 11/14/2013 6:54 PM, Kumar Srinivasan wrote:
> New full webrev:
> http://cr.openjdk.java.net/~ksrini/8023978/webrev.1/index.html
> Delta webrev wrt. webrev.0
> http://cr.openjdk.java.net/~ksrini/8023978/webrev.1/webrev.delta/index.html 

This looks much better.  Nit:  JAVA_LIB could be interpreted as jdk/lib 
which contains tools.jar etc which is the case when you run the test 
with jdk image.  If you run the test with JDK build, jdk/lib doesn't 
contain tools.jar (but its classes are in the bootclasspath).  JAVA_LIB 
is not currently used.  While there is no issue with it, perhaps better 
to take it out and define it when there is a concrete use of it.  It's 
really minor and will leave it up to you.


More information about the core-libs-dev mailing list