RFR: 8024140: [TESTBUG] Profile based regression test groups for jdk repo

Alan Bateman Alan.Bateman at oracle.com
Tue Sep 3 07:55:43 UTC 2013

On 03/09/2013 04:02, David Holmes wrote:
> webrev:
> http://cr.openjdk.java.net/~dholmes/8024140/webrev/
> :
> Note: once this is in place, anyone writing regression tests will need 
> to be aware of whether that test is limited to certain profiles and 
> update the group file accordingly. Sometimes it is not the item being 
> tested that determines the minimum needed profile, but the test 
> infrastructure eg if it uses XML.
I don't think this is very maintainable and I don't think we should 
force everyone that adds/changes tests to have to also maintain this 
file. In general I worry that this approach will just not scale when we 
move to modules. That said, I know you are under short term pressure to 
put in a solution to allow the profiles be tested.

So my view is that we should start looking for a replacement to this as 
soon as we can. In the mean-time then I think we have to assume that it 
will get out of sync periodically and maybe it's possible to provide 
tooling (maybe based on jdeps) that would help keep it up to date.

As regards the definitions then one observation is the TestNG tests that 
you've listed in needs_compact2 are actually compact1 tests. I wonder if 
this is a TestNG dependency on XML rather than dependencies in the test 

You've listed most of the tests in sun/nio/cs in needs_charsets and I 
wonder whether it would be simpler to just move these to sun/nio/cs/ext. 
We've already moved several tests (the ftp tests for example) in 
preparation for profiles and maybe this is an option here.

I see that needs_jre includes jdk_jdi but JDI is not in the JRE. Is it 
possible that you are testing JDI in the compile JDK here?


More information about the core-libs-dev mailing list