RFR: 8019853 - Break logging and AWT circular dependency
artem.ananiev at oracle.com
Tue Sep 3 14:16:45 UTC 2013
I only looked at AppContext.java changes, and they look fine. Line 870
looks redundant, indeed, on the other hand it shouldn't hurt as well.
Leaving it up to you.
On 8/30/2013 7:14 AM, Mandy Chung wrote:
> Hi Daniel,
> Thanks for getting this fixed. The change looks good. The
> JavaAWTContext.getAppletContext implementation looks good and clean
> (thanks to your comments). It'd be good to get AWT team to review
> AppContext.java change (cc'ing Artem).
> On 8/29/2013 1:13 PM, Daniel Fuchs wrote:
>> Please find below a changeset that will fix:
>> 8019853 - Break logging and AWT circular dependency
>> (which also duplicates
>> 8023258 Logger.getLogger() after ImageIO.read() returns
>> different logger instance)
>> The new code makes sure that JavaAWTAccess.getAppletContext() returns
>> null when the LogManager's default userContext should be used, thus
>> solving 8023258 (Logger.getLogger() after ImageIO.read() returns
>> different logger instance).
>> Although LogManager still needs to get the applet context it will no
>> longer trigger the creation of the 'mainAppContext' - thus breaking
>> the circular dependency.
>> best regards,
>> -- daniel
More information about the core-libs-dev