review request 7097386: Correct error in Predicate javadoc example

Lance Andersen - Oracle Lance.Andersen at
Mon Sep 16 11:12:09 UTC 2013

Thanks for the input.
On Sep 16, 2013, at 4:58 AM, Aleksey Shipilev wrote:

> On 09/15/2013 10:38 PM, Lance Andersen - Oracle wrote:
>> I added a webrev
>> as it might be
>> a bit easier for this review.
> Notes:
>  - change C-style "int v[]" declarations to Java-ish "int[] v".

I changed this.
>  - catching SQLException should probably return "false" right away?
True, was a missing cut and paste from the code I copied
>  - "if" block can float up to the exception handler block, eliminating
> the need for "int value = 0" line.

I left it as is as I try to keep the try/catch for SQLExceptions to just relevant code when applicable.
> Otherwise, looks good (not a Reviewer).
again, thank you for the feedback.

Changes are at

> Thanks,
> -Aleksey,

-------------- next part --------------

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at

More information about the core-libs-dev mailing list