RFR: 8039438: Some tests depend on internal API sun.misc.IOUtils

Alan Bateman Alan.Bateman at oracle.com
Wed Apr 9 18:42:16 UTC 2014

On 09/04/2014 17:00, Alexandre (Shura) Iline wrote:
> Hi.
> I'd like to ask for review of this fix:
> http://cr.openjdk.java.net/~shurailine/8039438/webrev.00/
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8039438
Looks okay to me.

For the class description then maybe something like "Defines useful I/O 
methods" might be a bit better than "Holds useful io shortcuts" but it's 
a minor point. I guess I would probably make it final and/or a private 
constructor to make it obvious that it just defines static methods.

A minor comment on LambdaClassLoaderSerialization.java is that would be 
good to indeed the tags so that they are consistent with other tests 
(pre-dates your change but more noticable now).


More information about the core-libs-dev mailing list