RFR [8040806]: BitSet.toString() can throw IndexOutOfBoundsException

Ivan Gerasimov ivan.gerasimov at oracle.com
Thu Apr 24 09:44:24 UTC 2014

Thanks Peter!

The test was designed to be laconic, so I tried to keep it this way.
I can, of course, include the mentioning of the exception in the message.
With the bug fixed it's not going to be shown anyway :)

Sincerely yours,

On 24.04.2014 11:24, Peter Levart wrote:
> Hi Ivan,
> This fix could be called: Leaving on the edge - A tricky game of 
> overflows :-)
> I think the fix is good. In the test it would be nice to include the 
> IndexOutOfBoundsException in the failure message to ease debugging.
> Regards, Peter
> On 04/22/2014 02:13 PM, Ivan Gerasimov wrote:
>> Hello!
>> If a BitSet has the bit Integer.MAX_VALUE set, then calling 
>> toString() will throw an exception.
>> The same thing happens if the bit (Integer.MAX_VALUE-1) is set.
>> Would you please help review the fix for this issue?
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8040806
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8040806/0/webrev/
>> Sincerely yours,
>> Ivan

More information about the core-libs-dev mailing list