Review request for JDK-8051536: Convert JAXP function tests: javax.xml.parsers to jtreg(testng) tests
lance.andersen at oracle.com
Tue Dec 2 14:33:20 UTC 2014
I think this looks good overall.
I might suggest that you consider utilizing the @BeforeMethod methods further, For example is SAXParserTest03.java you could move
SAXParserFactory spf = SAXParserFactory.newInstance();
to your @BeforeMethod, or consider using a DataProvider that is accessible from all classes to reduce some code duplication which will make maintenance a bit easier.
I am not sure how much more additional info failUnexpected adds, but you could omit this if you choose and just have the test method throw Exception and you will get your failure.
Again the above are suggestions, but should not prevent you pushing this to the workspace
On Dec 1, 2014, at 9:57 PM, Frank Yuan <frank.yuan at oracle.com> wrote:
> Hi, Joe and All
> We are working on moving internal jaxp functional tests to open jdk repo.
> This is the parsers suite. Would you please review these test? Any comment
> will be appreciated.
> bug: https://bugs.openjdk.java.net/browse/JDK-8051536
> webrev: http://cr.openjdk.java.net/~joehw/jdk9/test/Frank/8051536/webrev/
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
More information about the core-libs-dev