RFR (S) 6762191: Setting stack size to 16K causes segmentation fault
Alan.Bateman at oracle.com
Wed Dec 3 12:56:41 UTC 2014
On 02/12/2014 02:39, Chris Plummer wrote:
> Sorry about the long delay in getting back to this. I ran into two
> separate JPRT issues that were preventing me from testing these
> changes, plus I was on vacation last week. Here's an updated webrev.
> I'm not sure where we left things, so I'll just say what's changed
> since the original version:
> 1. Rewrote the test to be in Java instead of a shell script.
> 2. Moved the test from hotspot/test/runtime/memory to
> 3. Added STACK_SIZE_MINIMUM to java.c, allowing a makefile to override
> the default 32k minimum value.
This looks to me. A minor comment for java.c is that this code uses
4-space indent (different to hotspot).
The test looks okay too, you might just checking the copyright date as I
assume was not written in 2010. Also I think the import of java.io.File
may be left behind from the previous round.
More information about the core-libs-dev