RFR 8060068 : Remove the static initializer block from DriverManager
lance.andersen at oracle.com
Wed Dec 3 15:03:00 UTC 2014
On Dec 2, 2014, at 11:28 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> On 12/2/2014 1:47 PM, Lance Andersen wrote:
>> The revised webrev is here http://cr.openjdk.java.net/~lancea/8060068/webrev.03/
> Looks good. Nit: line 443 and a few places in the getConnection need a space in "for(", "if("
Thank you. I made a pass and should have caught them all
I built this against JDK 8u and all JCK tests pass. Also ran the unit tests and got the the expected tests to pass (these tests are only in JDK 9)
>> Note, I also tweaked the doPriviliged block for the JDBC property
> It's nice to see use of limited doPrivileged. Limited doPrivileged restricts the permissions be accessed by the doPrivileged block. On the other hand, since it only calls System.getProperty, that won't leak any privileges to untrusted code. I think we would need some guideline what can benefit from limited doPrivileged. Anyway, I'm fine with your change.
Trying to slowly add the limited doPrivileged when I do an update. We did the same in RowSetProvider earlier for the same reason.
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
More information about the core-libs-dev