RFR(S): 6977426: sun/tools tests can intermittently fail to find app's Java pid

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Tue Dec 16 16:41:50 UTC 2014

Hi Katja,

This request should probably go to core-libs as well.

Other than that I have just a few nits:


L57: if ("Logger".contains(args[0])) -> "Logger".equals(args[0]) ?
L127: // in LogManager.loggers that *arebeing* properly managed -> *are 

callLoggerAndCount() and callAnonymousLoggerAndCount() are using the 
'count' variable to always return 100. Could they be made to return a 
constant instead?



On 12/16/2014 04:57 PM, Yekaterina Kantserova wrote:
> Hi,
> Could I please have a review of this fix.
> bug: https://bugs.openjdk.java.net/browse/JDK-6977426
> webrev: http://cr.openjdk.java.net/~ykantser/6977426/webrev.00/
> java/util/logging/LoggerWeakRefLeak.sh and
> java/util/logging/AnonLoggerWeakRefLeak.sh are merged and rewritten in
> java. sun/tools/common/CommonTests.sh is removed because it doesn't test
> the product but sun/tool/common library functionality.
> Thanks,
> Katja

More information about the core-libs-dev mailing list