JDK 9 RFR of 8067964: Native2ascii doesn't close one of the streams it opens
chris.hegarty at oracle.com
Tue Dec 23 19:16:39 UTC 2014
Looks ok to me Brian.
Does the test really verify this? Or just exercise the code?
> On 23 Dec 2014, at 18:32, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> Please review at your convenience.
> Issue: https://bugs.openjdk.java.net/browse/JDK-8067964
> Patch: http://cr.openjdk.java.net/~bpb/8067964/webrev.00/
> Use try-with-resources statements to manage AutoCloseables in sun.tools.native2ascii.Main.convert(). Also clean up code formatting of the method and remove unneeded import statements.
More information about the core-libs-dev