RFR: JDK-8051563: Convert JAXP function tests in xslt components: : org.apache.qetest.dtm package, org.apache.qetest.trax package to openjdk

Lance @ Oracle lance.andersen at oracle.com
Tue Dec 30 23:07:19 UTC 2014

Hi Tristan,

I will look at this but doubt I will get to this tomorrow 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
Sent from my iPad

> On Dec 30, 2014, at 5:28 PM, Tristan Yan <tristan.yan at oracle.com> wrote:
> Hi All
> Can I get your review on this change.
> http://cr.openjdk.java.net/~tyan/8051563/webrev.00/ <http://cr.openjdk.java.net/~tyan/8051563/webrev.00/>
> These fixes originally come from bug https://bugs.openjdk.java.net/browse/JDK-8051563 <https://bugs.openjdk.java.net/browse/JDK-8051563> as part of our XML test colocation work. ThIS change-set mainly covers tests for package org.apache.qetest.dtm and org.apache.qetest.trax.
> In the meantime I took steps at fixing some of our existed test code on below issues:
> 1. Add a base test class for all functional tests that enable security manager running. A limited minimal permissions set have been set for every test.
> 2. Remove all unnecessary exception capture for functional tests that we’re using testng to handle all the exceptions.
> 3. Use try-resource block to solve all possible resource leaks (including InputStream, OutputStream, Writer, Reader). 
> Thanks a lot.
> Tristan

More information about the core-libs-dev mailing list