RFR(S): JDK-8033911 Simplify instrumentation of FileInputStream and RandomAccessFile

Staffan Larsen staffan.larsen at oracle.com
Fri Feb 7 13:25:43 UTC 2014

Alan, Jaroslav, Dmitry: Thanks!

On 7 feb 2014, at 12:38, Jaroslav Bachorik <jaroslav.bachorik at oracle.com> wrote:

> Looks good. Additional benefit is the compliance with the secure coding guide.
> -JB-
> On February 7, 2014 11:46:07 AM CET, Staffan Larsen <staffan.larsen at oracle.com> wrote:
> A few of the public read and write methods in FileInputStream and RandomAccessFile are declared native. This means that it is hard to instrument them using byte code instrumentation. Changing the public methods to be to non-native and instead calling private native methods simplifies instrumentation. 
> webrev: http://cr.openjdk.java.net/~sla/8033911/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8033911
> Thanks,
> /Staffan
> -- 
> Sent from my Android device with K-9 Mail. Please excuse my brevity.

More information about the core-libs-dev mailing list