RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only

Seán Coffey sean.coffey at oracle.com
Thu Feb 27 09:38:58 UTC 2014

On 27/02/2014 07:45, Alan Bateman wrote:
> On 26/02/2014 21:47, Seán Coffey wrote:
>> Good points Alan. Changes uploaded here :
>> http://cr.openjdk.java.net/~coffeys/webrev.8035618.v2/webrev/
> This looks much better. Are you sure that pmLock is needed? Is there 
> any reason not to synchronize on the AppContext when adding the 
> PresentationManager key?
I was conscious of possible contention coming on the AppContext object 
if syncing on it. I figured a static lock should work (given that we had 
zero synchronization in the old code) - Apologies for not including your 
name in final push. It's been pointed out to me that I should include 
all reviewers. I thought I could only include reviewers once I had an 'ok'.
> Are you planning to propose a fix for jdk9/dev too? It would be good 
> to eliminate the direct dependency on sun.awt.AppContext while doing 
> that.
Yes - I'll get the direct AppContext reference removed for JDK 9 fix via 
JavaAWTAccess but will need to re-examine the code to see if we can 
avoid sun.awt code.


> -Alan

More information about the core-libs-dev mailing list