RFR [6943190] TEST_BUG: java/lang/Runtime/exec/ExecWithInput.java hardcodes path to cat

roger riggs roger.riggs at oracle.com
Thu Feb 27 15:38:44 UTC 2014

Hi Ivan,

On 2/27/2014 4:34 AM, Ivan Gerasimov wrote:
>>  - I'm not sure the specific command methods do you any good
>>    (over a method with a string argument). since they immediately 
>> revert to the string command name.
> They are shorter :-)
yes, but it creates a level of indirection that someone reading the code 
has to chase through.
To me it would create less code and make for easier reading to call 
findCommand in all cases.

$.02, Roger

> Please find the updated webrev here:
> http://cr.openjdk.java.net/~igerasim/6943190/2/webrev/
> Sincerely yours,
> Ivan

More information about the core-libs-dev mailing list