RFR: JDK-8029007, Check src/share/native/sun/misc code for JNI pending exceptions
dan.xu at oracle.com
Fri Jan 10 17:46:18 UTC 2014
On 01/10/2014 02:32 AM, Alan Bateman wrote:
> On 10/01/2014 06:31, Dan Xu wrote:
>> Hi All,
>> Please review the fix for JNI pending exception issues reported in
>> jdk-8029007. Thanks!
>> Webrev: http://cr.openjdk.java.net/~dxu/8029007/webrev.00/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8029007
> This looks good, the only one that isn't clear (to me) is the
> GetStringLength usage in MessageUtil.c where I don't think it is
> possible to ever get < 0. This may be a case where you need to use
> ExceptionOccured instead.
According to jni.cpp, GetStringLength() will always return positive
value or 0. For simplicity, I will change "<= 0" to "== 0". Thanks, Alan.
More information about the core-libs-dev