RFR: JDK-8029007, Check src/share/native/sun/misc code for JNI pending exceptions
dan.xu at oracle.com
Fri Jan 10 18:07:08 UTC 2014
Yes, you are right. I just found this macro. It looks very handy to use.
On 01/10/2014 09:59 AM, roger riggs wrote:
> Hi Dan,
> One other comment, instead of changing the return type of the
> just return and the caller should check for exceptions and return.
> See jni.h: CHECK_EXCEPTION(env)
> On 1/10/2014 11:40 AM, roger riggs wrote:
>> Hi Dan,
>> Just pushed are macros in jni_util.h to do the same function as your
>> new macros.
>> Please update to use the common macros instead of introducing new ones.
>> Style wise, I would avoid mixing binary operators (!) with pointers.
>> it is clearer to compare with NULL. (The CHECK_NULL macro will do
>> the check and return).
>> (Not a Reviewer)
>> Thanks, Roger
>> On 1/10/2014 1:31 AM, Dan Xu wrote:
>>> Hi All,
>>> Please review the fix for JNI pending exception issues reported in
>>> jdk-8029007. Thanks!
>>> Webrev: http://cr.openjdk.java.net/~dxu/8029007/webrev.00/
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8029007
More information about the core-libs-dev