[8011944] Sort fails with ArrayIndexOutOfBoundsException

Alan Bateman Alan.Bateman at oracle.com
Fri Jan 24 09:33:13 UTC 2014

On 23/01/2014 22:55, Miroslaw Niemiec wrote:
> Hello!
> This is a simple backport from 8 to 7.
> Looking for a review of this even though it only requires a testcase 
> change due to the use of lambda expressions.
> Since this is the first of these I've encountered I thought I better 
> play it safe, but generally speaking, are we ok
> to skip the review process for backports like this? (minor lambda 
> related testcase changes - if the lambda's are in the actual fix it 
> probably makes sense to re-review).
It often happens that "small adjustments" are required when 
back-porting. To date then it's been a mix of just highlighting in the 
approval request to jdk7u-dev, sometimes the mailing list where the 
issue was originally reviewed is included. It's really just a judgement 
call as sometimes the adjustments are trivial, sometimes a bit more. The 
jdk7u maintainers are good about asking for additional review where it 
might be needed.

For cases like this one then it's best to start with the test pushed to 
the jdk8 forest and then just replace the use of new language features 
so that it compiles/runs on jdk7u. In this this case it seems okay, just 
make sure (as others have pointed out) not to remove the copyright header.


More information about the core-libs-dev mailing list