Review request: 8029548 (jdeps) use @jdk.Exported to determine supported vs JDK internal API
mandy.chung at oracle.com
Mon Jul 7 18:03:00 UTC 2014
On 7/4/14 11:04 AM, Alan Bateman wrote:
> On 25/06/2014 21:21, Mandy Chung wrote:
>> This patch is also intended to target for 8u40 backport. It fixes
>> the following issues:
>> JDK-8029548 (jdeps) use @jdk.Exported to determine supported vs JDK
>> internal API
>> JDK-8039007 jdeps incorrectly reports javax.jnlp as JDK internal APIs
>> JDK-8031092 jdeps does not recognize --help option.
>> JDK-8048063 (jdeps) Add filtering capability
>> Webrev at:
> I'm skimmed over this and it mostly looks okay. I'm not sure that I
> agree that JDK-8039007 is a bug, this is really just that it is
> missing @jdk.Exported as you noted in PlatformClassPath.
I think the right way to do is to add @jdk.Exported in javax.jnlp. I'll
follow up with deploy and check if they can annotate the exported APIs
in 8u40; if so, I can take this special case out from jdeps.
> The -filter options are useful but at the same time I have a concern
> that the number of options to jdeps is growing.
I shared the same concern. I had the -filter option in my first version
of jdeps but I didn't include it in the first push to jdeps. Currently
jdeps doesn't provide an easy way to find all package-level dependencies
as it always excludes the dependencies from the same JAR/archive. Both
cases are useful for developers in order to understand what APIs a
library/app is using. I think -filter option provides a convenient way
to specify what to be filtered rather than listing the packages in -p or
-e options. Do you have any other suggestion to avoid adding -filter
More information about the core-libs-dev