Review request: 8029548 (jdeps) use @jdk.Exported to determine supported vs JDK internal API

Mandy Chung mandy.chung at
Tue Jul 8 18:09:23 UTC 2014

Thanks Daniel.


On 7/8/14 8:21 AM, Daniel Fuchs wrote:
> Hi Mandy,
> On 7/8/14 4:59 PM, Mandy Chung wrote:
>> I took out the special case for javax.jnlp and follow up the change in
>> deploy to use @jdk.Exported to indicate its supportedness.  I also added
>> a new test case to check the dot file output:
> I installed the new patch and played with it, and I find the behavior
> of jdeps -R much clearer than in your first version.
> Thanks for clarifying the help messages too!
> Otherwise - I browsed through the changes and didn't see anything
> obviously wrong.
> best regards,
> -- daniel
>> thanks
>> Mandy
>> On 6/25/14 1:21 PM, Mandy Chung wrote:
>>> This patch is also intended to target for 8u40 backport.  It fixes
>>> the following issues:
>>> JDK-8029548 (jdeps) use @jdk.Exported to determine supported vs JDK
>>> internal API
>>> JDK-8039007 jdeps incorrectly reports javax.jnlp as JDK internal APIs
>>> JDK-8031092 jdeps does not recognize --help option.
>>> JDK-8048063 (jdeps) Add filtering capability
>>> Webrev at:
>>> jdeps will determine if it's a JDK internal API by checking the
>>> @jdk.Exported.
>>> It also reads tools.jar and flags if they are non-exported. 
>>> javax.jnlp is
>>> supported API but not annotated with @jdk.Exported and so we special 
>>> case
>>> it as a workaround. A new -filter option is added to provide an easy
>>> way to do filtering e.g. -filter java.lang.*, -filter:archive to filter
>>> out all dependences from the same archive (i.e the input JAR file or
>>> directory).  The default is changed to filter out the dependences
>>> within the same package.  I also have cleaned up and refactored some 
>>> code
>>> between JdepsTask and Analyzer to prepare for source restructuring
>>> and modularization work.
>>> thanks
>>> Mandy

More information about the core-libs-dev mailing list